can_rate? can not deal with dimension = nil #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,10 @@ def average(dimension=nil) | |||
| end | |||
|
|
|||
| def can_rate?(user_id, dimension=nil) | |||
| val = self.connection.select_value("select count(*) as cnt from rates where rateable_id=#{self.id} and rateable_type='#{self.class.name}' and rater_id=#{user_id} and dimension='#{dimension}'").to_i | |||
| query = "select count(*) as cnt from rates where rateable_id=#{self.id} and rateable_type='#{self.class.name}' and rater_id=#{user_id} " | |||
There was a problem hiding this comment.
both the old version and this one don't work with inheritance because the polymorphic association will use the class.parent_name instead of class.name
There was a problem hiding this comment.
a better approach would be let active record help us, something like:
val = rates.select_value("count(*) as cnt").where(dimension: dimension, rater_id: user_id)There was a problem hiding this comment.
this code is much simpler and will work find with model inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dimension.nil? , query should be " dimension is null ", not "dimension = '' ".